Use default destructor, and add move/copy operators to settings impls

scwx-qt/source/scwx/qt/settings/alert_palette_settings.cpp

@@ -135,7 +135,12 @@ public:
 
       SetDefaultLineData(inactive_, kInactivePalettes_.at(phenomenon));
    }
-   ~Impl() {}
+
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    static void SetDefaultLineData(LineSettings&   lineSettings,
                                   const LineData& lineData);

scwx-qt/source/scwx/qt/settings/audio_settings.cpp

@@ -92,7 +92,11 @@ public:
                             SettingsVariable<bool> {"alert_disabled"});
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    SettingsVariable<std::string> alertSoundFile_ {"alert_sound_file"};
    SettingsVariable<std::string> alertLocationMethod_ {"alert_location_method"};

scwx-qt/source/scwx/qt/settings/general_settings.cpp

@@ -140,7 +140,11 @@ public:
          { return QUrl {QString::fromStdString(value)}.isValid(); });
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    SettingsVariable<bool>        antiAliasingEnabled_ {"anti_aliasing_enabled"};
    SettingsVariable<std::string> clockFormat_ {"clock_format"};

scwx-qt/source/scwx/qt/settings/hotkey_settings.cpp

@@ -90,7 +90,11 @@ public:
                       SettingsVariable<std::string> {"?"});
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    std::unordered_map<types::Hotkey, SettingsVariable<std::string>> hotkey_ {};
    std::vector<SettingsVariableBase*> variables_ {};

scwx-qt/source/scwx/qt/settings/line_settings.cpp

@@ -46,7 +46,12 @@ public:
       highlightColor_.SetValidator(&util::color::ValidateArgbString);
       borderColor_.SetValidator(&util::color::ValidateArgbString);
    }
-   ~Impl() {}
+
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    SettingsVariable<std::string> lineColor_ {"line_color"};
    SettingsVariable<std::string> highlightColor_ {"highlight_color"};

scwx-qt/source/scwx/qt/settings/map_settings.cpp

@@ -100,7 +100,11 @@ public:
       }
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    void SetDefaults(std::size_t i)
    {

scwx-qt/source/scwx/qt/settings/palette_settings.cpp

@@ -79,7 +79,11 @@ public:
       InitializeAlerts();
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    void InitializeColorTables();
    void InitializeLegacyAlerts();

scwx-qt/source/scwx/qt/settings/product_settings.cpp

@@ -19,7 +19,11 @@ public:
       // NOLINTEND(cppcoreguidelines-avoid-magic-numbers)
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    SettingsVariable<bool> showSmoothedRangeFolding_ {
       "show_smoothed_range_folding"};

scwx-qt/source/scwx/qt/settings/settings_category.cpp

@@ -15,7 +15,11 @@ class SettingsCategory::Impl
 public:
    explicit Impl(const std::string& name) : name_ {name} {}
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    void ConnectSubcategory(SettingsCategory& category);
    void ConnectVariable(SettingsVariableBase* variable);

scwx-qt/source/scwx/qt/settings/settings_container.cpp

@@ -11,9 +11,13 @@ template<class Container>
 class SettingsContainer<Container>::Impl
 {
 public:
-   explicit Impl() {}
+   explicit Impl() = default;
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    T                             elementDefault_ {};
    std::optional<T>              elementMinimum_ {};

scwx-qt/source/scwx/qt/settings/settings_interface.cpp

@@ -27,7 +27,11 @@ public:
       context_->moveToThread(QCoreApplication::instance()->thread());
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    template<class U>
    void SetWidgetText(U* widget, const T& currentValue);

scwx-qt/source/scwx/qt/settings/settings_interface_base.cpp

@@ -11,8 +11,12 @@ static const std::string logPrefix_ =
 class SettingsInterfaceBase::Impl
 {
 public:
-   explicit Impl() {}
+   explicit Impl()               = default;
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 };
 
 SettingsInterfaceBase::SettingsInterfaceBase() : p(std::make_unique<Impl>()) {}

scwx-qt/source/scwx/qt/settings/settings_variable.cpp

@@ -17,8 +17,12 @@ template<class T>
 class SettingsVariable<T>::Impl
 {
 public:
-   explicit Impl() {}
+   explicit Impl()               = default;
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    T                             value_ {};
    T                             default_ {};

scwx-qt/source/scwx/qt/settings/settings_variable_base.cpp

@@ -11,7 +11,11 @@ class SettingsVariableBase::Impl
 public:
    explicit Impl(const std::string& name) : name_ {name} {}
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    const std::string name_;
 

scwx-qt/source/scwx/qt/settings/text_settings.cpp

@@ -80,7 +80,11 @@ public:
       InitializeFontVariables();
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    void InitializeFontVariables();
 

scwx-qt/source/scwx/qt/settings/ui_settings.cpp

@@ -22,7 +22,11 @@ public:
       // NOLINTEND(cppcoreguidelines-avoid-magic-numbers)
    }
 
-   ~UiSettingsImpl() {}
+   ~UiSettingsImpl()                                 = default;
+   UiSettingsImpl(const UiSettingsImpl&)             = delete;
+   UiSettingsImpl& operator=(const UiSettingsImpl&)  = delete;
+   UiSettingsImpl(const UiSettingsImpl&&)            = delete;
+   UiSettingsImpl& operator=(const UiSettingsImpl&&) = delete;
 
    SettingsVariable<bool> level2ProductsExpanded_ {"level2_products_expanded"};
    SettingsVariable<bool> level2SettingsExpanded_ {"level2_settings_expanded"};

scwx-qt/source/scwx/qt/settings/unit_settings.cpp

@@ -62,7 +62,11 @@ public:
                                       types::GetDistanceUnitsName));
    }
 
-   ~Impl() {}
+   ~Impl()                       = default;
+   Impl(const Impl&)             = delete;
+   Impl& operator=(const Impl&)  = delete;
+   Impl(const Impl&&)            = delete;
+   Impl& operator=(const Impl&&) = delete;
 
    SettingsVariable<std::string> accumulationUnits_ {"accumulation_units"};
    SettingsVariable<std::string> echoTopsUnits_ {"echo_tops_units"};