Base classes should have destructors defined as virtual

This commit is contained in:
Dan Paulat 2022-06-04 09:56:51 -05:00
parent d041e7e217
commit 1974fbbc93
3 changed files with 3 additions and 3 deletions

View file

@ -23,7 +23,7 @@ class Level3ProductView : public RadarProductView
public: public:
explicit Level3ProductView(const std::string& product); explicit Level3ProductView(const std::string& product);
~Level3ProductView(); virtual ~Level3ProductView();
const std::vector<boost::gil::rgba8_pixel_t>& color_table() const override; const std::vector<boost::gil::rgba8_pixel_t>& color_table() const override;
uint16_t color_table_min() const override; uint16_t color_table_min() const override;

View file

@ -16,7 +16,7 @@ public:
explicit AwsNexradDataProvider(const std::string& radarSite, explicit AwsNexradDataProvider(const std::string& radarSite,
const std::string& bucketName, const std::string& bucketName,
const std::string& region); const std::string& region);
~AwsNexradDataProvider(); virtual ~AwsNexradDataProvider();
AwsNexradDataProvider(const AwsNexradDataProvider&) = delete; AwsNexradDataProvider(const AwsNexradDataProvider&) = delete;
AwsNexradDataProvider& operator=(const AwsNexradDataProvider&) = delete; AwsNexradDataProvider& operator=(const AwsNexradDataProvider&) = delete;

View file

@ -15,7 +15,7 @@ class NexradDataProvider
{ {
public: public:
explicit NexradDataProvider(); explicit NexradDataProvider();
~NexradDataProvider(); virtual ~NexradDataProvider();
NexradDataProvider(const NexradDataProvider&) = delete; NexradDataProvider(const NexradDataProvider&) = delete;
NexradDataProvider& operator=(const NexradDataProvider&) = delete; NexradDataProvider& operator=(const NexradDataProvider&) = delete;