From 1fbb5e5387b220ec6ca86757150873183da04470 Mon Sep 17 00:00:00 2001 From: Dan Paulat Date: Sat, 8 Jan 2022 15:16:54 -0600 Subject: [PATCH] Zero initialize level 3 data fields --- ...igital_precipitation_data_array_packet.cpp | 4 +- .../scwx/wsr88d/rpg/level3_message_header.cpp | 16 +++--- .../rpg/linked_contour_vector_packet.cpp | 14 ++--- .../scwx/wsr88d/rpg/linked_vector_packet.cpp | 14 ++--- .../precipitation_rate_data_array_packet.cpp | 4 +- .../wsr88d/rpg/product_description_block.cpp | 52 ++++++++++--------- .../wsr88d/rpg/product_symbology_block.cpp | 8 ++- .../scwx/wsr88d/rpg/radial_data_packet.cpp | 5 +- .../scwx/wsr88d/rpg/raster_data_packet.cpp | 4 +- .../wsr88d/rpg/set_color_level_packet.cpp | 4 +- .../rpg/text_and_special_symbol_packet.cpp | 14 ++--- .../rpg/unlinked_contour_vector_packet.cpp | 8 +-- .../wsr88d/rpg/unlinked_vector_packet.cpp | 10 ++-- wxdata/source/scwx/wsr88d/rpg/wmo_header.cpp | 4 +- 14 files changed, 97 insertions(+), 64 deletions(-) diff --git a/wxdata/source/scwx/wsr88d/rpg/digital_precipitation_data_array_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/digital_precipitation_data_array_packet.cpp index b5e0c595..6b8abb8b 100644 --- a/wxdata/source/scwx/wsr88d/rpg/digital_precipitation_data_array_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/digital_precipitation_data_array_packet.cpp @@ -32,7 +32,9 @@ public: numberOfLfmBoxesInRow_ {0}, numberOfRows_ {0}, row_ {}, - dataSize_ {0} {}; + dataSize_ {0} + { + } ~DigitalPrecipitationDataArrayPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/level3_message_header.cpp b/wxdata/source/scwx/wsr88d/rpg/level3_message_header.cpp index 0c0c0f74..8617edae 100644 --- a/wxdata/source/scwx/wsr88d/rpg/level3_message_header.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/level3_message_header.cpp @@ -25,13 +25,15 @@ class Level3MessageHeaderImpl { public: explicit Level3MessageHeaderImpl() : - messageCode_ {}, - dateOfMessage_ {}, - timeOfMessage_ {}, - lengthOfMessage_ {}, - sourceId_ {}, - destinationId_ {}, - numberBlocks_ {} {}; + messageCode_ {0}, + dateOfMessage_ {0}, + timeOfMessage_ {0}, + lengthOfMessage_ {0}, + sourceId_ {0}, + destinationId_ {0}, + numberBlocks_ {0} + { + } ~Level3MessageHeaderImpl() = default; int16_t messageCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/linked_contour_vector_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/linked_contour_vector_packet.cpp index 9671043e..d08ce9c1 100644 --- a/wxdata/source/scwx/wsr88d/rpg/linked_contour_vector_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/linked_contour_vector_packet.cpp @@ -19,13 +19,15 @@ class LinkedContourVectorPacketImpl { public: explicit LinkedContourVectorPacketImpl() : - packetCode_ {}, - initialPointIndicator_ {}, - lengthOfVectors_ {}, - startI_ {}, - startJ_ {}, + packetCode_ {0}, + initialPointIndicator_ {0}, + lengthOfVectors_ {0}, + startI_ {0}, + startJ_ {0}, endI_ {}, - endJ_ {} {}; + endJ_ {} + { + } ~LinkedContourVectorPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/linked_vector_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/linked_vector_packet.cpp index 7a114d42..a026252b 100644 --- a/wxdata/source/scwx/wsr88d/rpg/linked_vector_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/linked_vector_packet.cpp @@ -19,13 +19,15 @@ class LinkedVectorPacketImpl { public: explicit LinkedVectorPacketImpl() : - packetCode_ {}, - lengthOfBlock_ {}, - valueOfVector_ {}, - startI_ {}, - startJ_ {}, + packetCode_ {0}, + lengthOfBlock_ {0}, + valueOfVector_ {0}, + startI_ {0}, + startJ_ {0}, endI_ {}, - endJ_ {} {}; + endJ_ {} + { + } ~LinkedVectorPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/precipitation_rate_data_array_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/precipitation_rate_data_array_packet.cpp index 4e9f0f5d..6d405195 100644 --- a/wxdata/source/scwx/wsr88d/rpg/precipitation_rate_data_array_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/precipitation_rate_data_array_packet.cpp @@ -31,7 +31,9 @@ public: numberOfLfmBoxesInRow_ {0}, numberOfRows_ {0}, row_ {}, - dataSize_ {0} {}; + dataSize_ {0} + { + } ~PrecipitationRateDataArrayPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/product_description_block.cpp b/wxdata/source/scwx/wsr88d/rpg/product_description_block.cpp index 68bbf4e4..c47b4c0a 100644 --- a/wxdata/source/scwx/wsr88d/rpg/product_description_block.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/product_description_block.cpp @@ -25,31 +25,33 @@ class ProductDescriptionBlockImpl { public: explicit ProductDescriptionBlockImpl() : - blockDivider_ {}, - latitudeOfRadar_ {}, - longitudeOfRadar_ {}, - heightOfRadar_ {}, - productCode_ {}, - operationalMode_ {}, - volumeCoveragePattern_ {}, - sequenceNumber_ {}, - volumeScanNumber_ {}, - volumeScanDate_ {}, - volumeScanStartTime_ {}, - generationDateOfProduct_ {}, - generationTimeOfProduct_ {}, - elevationNumber_ {}, - halfword31_ {}, - halfword32_ {}, - halfword33_ {}, - halfword34_ {}, - halfword35_ {}, - version_ {}, - spotBlank_ {}, - offsetToSymbology_ {}, - offsetToGraphic_ {}, - offsetToTabular_ {}, - parameters_ {} {}; + blockDivider_ {0}, + latitudeOfRadar_ {0}, + longitudeOfRadar_ {0}, + heightOfRadar_ {0}, + productCode_ {0}, + operationalMode_ {0}, + volumeCoveragePattern_ {0}, + sequenceNumber_ {0}, + volumeScanNumber_ {0}, + volumeScanDate_ {0}, + volumeScanStartTime_ {0}, + generationDateOfProduct_ {0}, + generationTimeOfProduct_ {0}, + elevationNumber_ {0}, + halfword31_ {0}, + halfword32_ {0}, + halfword33_ {0}, + halfword34_ {0}, + halfword35_ {0}, + version_ {0}, + spotBlank_ {0}, + offsetToSymbology_ {0}, + offsetToGraphic_ {0}, + offsetToTabular_ {0}, + parameters_ {0} + { + } ~ProductDescriptionBlockImpl() = default; int16_t blockDivider_; diff --git a/wxdata/source/scwx/wsr88d/rpg/product_symbology_block.cpp b/wxdata/source/scwx/wsr88d/rpg/product_symbology_block.cpp index 6ec51823..c2af7ee5 100644 --- a/wxdata/source/scwx/wsr88d/rpg/product_symbology_block.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/product_symbology_block.cpp @@ -20,7 +20,13 @@ class ProductSymbologyBlockImpl { public: explicit ProductSymbologyBlockImpl() : - blockDivider_ {}, blockId_ {}, lengthOfBlock_ {}, numberOfLayers_ {} {}; + blockDivider_ {0}, + blockId_ {0}, + lengthOfBlock_ {0}, + numberOfLayers_ {0}, + layerList_ {} + { + } ~ProductSymbologyBlockImpl() = default; int16_t blockDivider_; diff --git a/wxdata/source/scwx/wsr88d/rpg/radial_data_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/radial_data_packet.cpp index 3c36588d..33fa8fbe 100644 --- a/wxdata/source/scwx/wsr88d/rpg/radial_data_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/radial_data_packet.cpp @@ -38,7 +38,10 @@ public: iCenterOfSweep_ {0}, jCenterOfSweep_ {0}, scaleFactor_ {0}, - dataSize_ {0} {}; + radial_ {}, + dataSize_ {0} + { + } ~RadialDataPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/raster_data_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/raster_data_packet.cpp index 3ac1a464..fb0bf908 100644 --- a/wxdata/source/scwx/wsr88d/rpg/raster_data_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/raster_data_packet.cpp @@ -38,7 +38,9 @@ public: numberOfRows_ {0}, packagingDescriptor_ {0}, row_ {}, - dataSize_ {0} {}; + dataSize_ {0} + { + } ~RasterDataPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/set_color_level_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/set_color_level_packet.cpp index a1a38f90..0d487f09 100644 --- a/wxdata/source/scwx/wsr88d/rpg/set_color_level_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/set_color_level_packet.cpp @@ -19,7 +19,9 @@ class SetColorLevelPacketImpl { public: explicit SetColorLevelPacketImpl() : - packetCode_ {}, colorValueIndicator_ {}, valueOfContour_ {} {}; + packetCode_ {0}, colorValueIndicator_ {0}, valueOfContour_ {0} + { + } ~SetColorLevelPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/text_and_special_symbol_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/text_and_special_symbol_packet.cpp index 2e373097..cefa5db5 100644 --- a/wxdata/source/scwx/wsr88d/rpg/text_and_special_symbol_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/text_and_special_symbol_packet.cpp @@ -19,12 +19,14 @@ class TextAndSpecialSymbolPacketImpl { public: explicit TextAndSpecialSymbolPacketImpl() : - packetCode_ {}, - lengthOfBlock_ {}, - valueOfText_ {}, - startI_ {}, - startJ_ {}, - characters_ {} {}; + packetCode_ {0}, + lengthOfBlock_ {0}, + valueOfText_ {0}, + startI_ {0}, + startJ_ {0}, + characters_ {} + { + } ~TextAndSpecialSymbolPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/unlinked_contour_vector_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/unlinked_contour_vector_packet.cpp index 0f287c34..e9d636d0 100644 --- a/wxdata/source/scwx/wsr88d/rpg/unlinked_contour_vector_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/unlinked_contour_vector_packet.cpp @@ -19,12 +19,14 @@ class UnlinkedContourVectorPacketImpl { public: explicit UnlinkedContourVectorPacketImpl() : - packetCode_ {}, - lengthOfVectors_ {}, + packetCode_ {0}, + lengthOfVectors_ {0}, beginI_ {}, beginJ_ {}, endI_ {}, - endJ_ {} {}; + endJ_ {} + { + } ~UnlinkedContourVectorPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/unlinked_vector_packet.cpp b/wxdata/source/scwx/wsr88d/rpg/unlinked_vector_packet.cpp index 06235e96..18092d92 100644 --- a/wxdata/source/scwx/wsr88d/rpg/unlinked_vector_packet.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/unlinked_vector_packet.cpp @@ -19,13 +19,15 @@ class UnlinkedVectorPacketImpl { public: explicit UnlinkedVectorPacketImpl() : - packetCode_ {}, - lengthOfBlock_ {}, - valueOfVector_ {}, + packetCode_ {0}, + lengthOfBlock_ {0}, + valueOfVector_ {0}, beginI_ {}, beginJ_ {}, endI_ {}, - endJ_ {} {}; + endJ_ {} + { + } ~UnlinkedVectorPacketImpl() = default; uint16_t packetCode_; diff --git a/wxdata/source/scwx/wsr88d/rpg/wmo_header.cpp b/wxdata/source/scwx/wsr88d/rpg/wmo_header.cpp index bf56d480..d71285ea 100644 --- a/wxdata/source/scwx/wsr88d/rpg/wmo_header.cpp +++ b/wxdata/source/scwx/wsr88d/rpg/wmo_header.cpp @@ -34,7 +34,9 @@ public: dateTime_ {}, bbbIndicator_ {}, productCategory_ {}, - productDesignator_ {} {}; + productDesignator_ {} + { + } ~WmoHeaderImpl() = default; std::string sequenceNumber_;