blakeridgway/supercell-wx
1
0
Fork 0
mirror of https://github.com/ciphervance/supercell-wx.git synced 2025-11-02 06:20:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Unregister settings callbacks on layer destruction

Browse source 
Fixes #151
This commit is contained in:
Dan Paulat 2024-02-28 22:37:22 -06:00
parent 721e3a163e
commit 35f29a794b
3 changed files with 89 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

43
scwx-qt/source/scwx/qt/map/overlay_product_layer.cpp
View file

@ -31,28 +31,38 @@ public:
{
auto& productSettings = settings::ProductSettings::Instance();
productSettings.sti_forecast_enabled().RegisterValueStagedCallback(
[=, this](const bool& value)
{
stiForecastEnabled_ = value;
stiNeedsUpdate_ = true;
stiForecastEnabledCallbackUuid_ =
productSettings.sti_forecast_enabled().RegisterValueStagedCallback(
[=, this](const bool& value)
{
stiForecastEnabled_ = value;
stiNeedsUpdate_ = true;
Q_EMIT self_->NeedsRendering();
});
productSettings.sti_past_enabled().RegisterValueStagedCallback(
[=, this](const bool& value)
{
stiPastEnabled_ = value;
stiNeedsUpdate_ = true;
Q_EMIT self_->NeedsRendering();
});
stiPastEnabledCallbackUuid_ =
productSettings.sti_past_enabled().RegisterValueStagedCallback(
[=, this](const bool& value)
{
stiPastEnabled_ = value;
stiNeedsUpdate_ = true;
Q_EMIT self_->NeedsRendering();
});
Q_EMIT self_->NeedsRendering();
});
stiForecastEnabled_ =
productSettings.sti_forecast_enabled().GetStagedOrValue();
stiPastEnabled_ = productSettings.sti_past_enabled().GetStagedOrValue();
}
~Impl() = default;
~Impl()
{
auto& productSettings = settings::ProductSettings::Instance();
productSettings.sti_forecast_enabled().UnregisterValueStagedCallback(
stiForecastEnabledCallbackUuid_);
productSettings.sti_past_enabled().UnregisterValueStagedCallback(
stiPastEnabledCallbackUuid_);
}
void UpdateStormTrackingInformation();
@ -87,6 +97,9 @@ public:
OverlayProductLayer* self_;
boost::uuids::uuid stiForecastEnabledCallbackUuid_;
boost::uuids::uuid stiPastEnabledCallbackUuid_;
bool stiForecastEnabled_ {true};
bool stiPastEnabled_ {true};