blakeridgway/supercell-wx
1
0
Fork 0
mirror of https://github.com/ciphervance/supercell-wx.git synced 2025-10-30 22:40:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove warning supression and fix missing virtual destructor

Browse source
This commit is contained in:
AdenKoperczak 2024-09-21 13:01:56 -04:00
parent c5d004aa48
commit 3b5323cea0
5 changed files with 2 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scwx-qt/source/scwx/qt/gl/draw/draw_item.hpp
View file

@ -22,7 +22,7 @@ class DrawItem
{ {
public: public:
explicit DrawItem(OpenGLFunctions& gl); explicit DrawItem(OpenGLFunctions& gl);
~DrawItem(); virtual ~DrawItem();
DrawItem(const DrawItem&) = delete; DrawItem(const DrawItem&) = delete;
DrawItem& operator=(const DrawItem&) = delete; DrawItem& operator=(const DrawItem&) = delete;

9
scwx-qt/source/scwx/qt/gl/gl.hpp
View file

@ -1,16 +1,7 @@
#pragma once #pragma once
#if defined(__clang__)
# pragma clang diagnostic push
# pragma clang diagnostic ignored "-Wdelete-non-abstract-non-virtual-dtor"
#endif
#include <QOpenGLFunctions_3_3_Core> #include <QOpenGLFunctions_3_3_Core>
#if defined(__clang__)
# pragma clang diagnostic pop
#endif
#define SCWX_GL_CHECK_ERROR() \ #define SCWX_GL_CHECK_ERROR() \
{ \ { \
GLenum err; \ GLenum err; \

9
scwx-qt/source/scwx/qt/map/alert_layer.hpp
View file

@ -1,16 +1,7 @@
#pragma once #pragma once
#if defined(__clang__)
# pragma clang diagnostic push
# pragma clang diagnostic ignored "-Wdelete-non-abstract-non-virtual-dtor"
#endif
#include <scwx/awips/phenomenon.hpp> #include <scwx/awips/phenomenon.hpp>
#if defined(__clang__)
# pragma clang diagnostic pop
#endif
#include <scwx/qt/map/draw_layer.hpp> #include <scwx/qt/map/draw_layer.hpp>
#include <scwx/qt/types/text_event_key.hpp> #include <scwx/qt/types/text_event_key.hpp>

2
scwx-qt/source/scwx/qt/settings/settings_category.hpp
View file

@ -18,7 +18,7 @@ class SettingsCategory
{ {
public: public:
explicit SettingsCategory(const std::string& name); explicit SettingsCategory(const std::string& name);
~SettingsCategory(); virtual ~SettingsCategory();
SettingsCategory(const SettingsCategory&) = delete; SettingsCategory(const SettingsCategory&) = delete;
SettingsCategory& operator=(const SettingsCategory&) = delete; SettingsCategory& operator=(const SettingsCategory&) = delete;

9
scwx-qt/source/scwx/qt/settings/text_settings.cpp
View file

@ -1,17 +1,8 @@
#if defined(__clang__)
# pragma clang diagnostic push
# pragma clang diagnostic ignored "-Wdelete-non-abstract-non-virtual-dtor"
#endif
#include <scwx/qt/settings/text_settings.hpp> #include <scwx/qt/settings/text_settings.hpp>
#include <scwx/qt/types/text_types.hpp> #include <scwx/qt/types/text_types.hpp>
#include <boost/algorithm/string.hpp> #include <boost/algorithm/string.hpp>
#if defined(__clang__)
# pragma clang diagnostic pop
#endif
namespace scwx namespace scwx
{ {
namespace qt namespace qt