RPG clang-tidy cleanup

This commit is contained in:
Dan Paulat 2025-05-17 00:18:07 -05:00
parent e49adafda9
commit 68a5baa5c4
6 changed files with 223 additions and 204 deletions

View file

@ -2,29 +2,22 @@
#include <scwx/wsr88d/rpg/level3_message.hpp>
namespace scwx
{
namespace wsr88d
{
namespace rpg
namespace scwx::wsr88d::rpg
{
class Level3MessageFactory
{
private:
public:
explicit Level3MessageFactory() = delete;
~Level3MessageFactory() = delete;
Level3MessageFactory(const Level3MessageFactory&) = delete;
Level3MessageFactory(const Level3MessageFactory&) = delete;
Level3MessageFactory& operator=(const Level3MessageFactory&) = delete;
Level3MessageFactory(Level3MessageFactory&&) noexcept = delete;
Level3MessageFactory(Level3MessageFactory&&) noexcept = delete;
Level3MessageFactory& operator=(Level3MessageFactory&&) noexcept = delete;
public:
static std::shared_ptr<Level3Message> Create(std::istream& is);
};
} // namespace rpg
} // namespace wsr88d
} // namespace scwx
} // namespace scwx::wsr88d::rpg

View file

@ -2,29 +2,22 @@
#include <scwx/wsr88d/rpg/packet.hpp>
namespace scwx
{
namespace wsr88d
{
namespace rpg
namespace scwx::wsr88d::rpg
{
class PacketFactory
{
private:
public:
explicit PacketFactory() = delete;
~PacketFactory() = delete;
PacketFactory(const PacketFactory&) = delete;
PacketFactory(const PacketFactory&) = delete;
PacketFactory& operator=(const PacketFactory&) = delete;
PacketFactory(PacketFactory&&) noexcept = delete;
PacketFactory(PacketFactory&&) noexcept = delete;
PacketFactory& operator=(PacketFactory&&) noexcept = delete;
public:
static std::shared_ptr<Packet> Create(std::istream& is);
};
} // namespace rpg
} // namespace wsr88d
} // namespace scwx
} // namespace scwx::wsr88d::rpg

View file

@ -12,8 +12,6 @@
namespace scwx::wsr88d::rpg
{
class ProductDescriptionBlockImpl;
class ProductDescriptionBlock : public awips::Message
{
public:
@ -26,38 +24,38 @@ public:
ProductDescriptionBlock(ProductDescriptionBlock&&) noexcept;
ProductDescriptionBlock& operator=(ProductDescriptionBlock&&) noexcept;
[[nodiscard]] int16_t block_divider() const;
[[nodiscard]] float latitude_of_radar() const;
[[nodiscard]] float longitude_of_radar() const;
[[nodiscard]] int16_t height_of_radar() const;
[[nodiscard]] int16_t product_code() const;
[[nodiscard]] uint16_t operational_mode() const;
[[nodiscard]] uint16_t volume_coverage_pattern() const;
[[nodiscard]] int16_t sequence_number() const;
[[nodiscard]] uint16_t volume_scan_number() const;
[[nodiscard]] uint16_t volume_scan_date() const;
[[nodiscard]] uint32_t volume_scan_start_time() const;
[[nodiscard]] uint16_t generation_date_of_product() const;
[[nodiscard]] uint32_t generation_time_of_product() const;
[[nodiscard]] uint16_t elevation_number() const;
[[nodiscard]] uint16_t data_level_threshold(size_t i) const;
[[nodiscard]] uint8_t version() const;
[[nodiscard]] uint8_t spot_blank() const;
[[nodiscard]] uint32_t offset_to_symbology() const;
[[nodiscard]] uint32_t offset_to_graphic() const;
[[nodiscard]] uint32_t offset_to_tabular() const;
[[nodiscard]] std::int16_t block_divider() const;
[[nodiscard]] float latitude_of_radar() const;
[[nodiscard]] float longitude_of_radar() const;
[[nodiscard]] std::int16_t height_of_radar() const;
[[nodiscard]] std::int16_t product_code() const;
[[nodiscard]] std::uint16_t operational_mode() const;
[[nodiscard]] std::uint16_t volume_coverage_pattern() const;
[[nodiscard]] std::int16_t sequence_number() const;
[[nodiscard]] std::uint16_t volume_scan_number() const;
[[nodiscard]] std::uint16_t volume_scan_date() const;
[[nodiscard]] std::uint32_t volume_scan_start_time() const;
[[nodiscard]] std::uint16_t generation_date_of_product() const;
[[nodiscard]] std::uint32_t generation_time_of_product() const;
[[nodiscard]] std::uint16_t elevation_number() const;
[[nodiscard]] std::uint16_t data_level_threshold(size_t i) const;
[[nodiscard]] std::uint8_t version() const;
[[nodiscard]] std::uint8_t spot_blank() const;
[[nodiscard]] std::uint32_t offset_to_symbology() const;
[[nodiscard]] std::uint32_t offset_to_graphic() const;
[[nodiscard]] std::uint32_t offset_to_tabular() const;
[[nodiscard]] float range() const;
[[nodiscard]] uint16_t range_raw() const;
[[nodiscard]] float x_resolution() const;
[[nodiscard]] uint16_t x_resolution_raw() const;
[[nodiscard]] float y_resolution() const;
[[nodiscard]] uint16_t y_resolution_raw() const;
[[nodiscard]] float range() const;
[[nodiscard]] std::uint16_t range_raw() const;
[[nodiscard]] float x_resolution() const;
[[nodiscard]] std::uint16_t x_resolution_raw() const;
[[nodiscard]] float y_resolution() const;
[[nodiscard]] std::uint16_t y_resolution_raw() const;
[[nodiscard]] uint16_t threshold() const;
[[nodiscard]] float offset() const;
[[nodiscard]] float scale() const;
[[nodiscard]] uint16_t number_of_levels() const;
[[nodiscard]] std::uint16_t threshold() const;
[[nodiscard]] float offset() const;
[[nodiscard]] float scale() const;
[[nodiscard]] std::uint16_t number_of_levels() const;
[[nodiscard]] std::optional<DataLevelCode>
data_level_code(std::uint8_t level) const;
@ -78,14 +76,15 @@ public:
[[nodiscard]] bool IsCompressionEnabled() const;
[[nodiscard]] bool IsDataLevelCoded() const;
[[nodiscard]] size_t data_size() const override;
[[nodiscard]] std::size_t data_size() const override;
bool Parse(std::istream& is) override;
static constexpr size_t SIZE = 102u;
static constexpr std::size_t SIZE = 102u;
private:
std::unique_ptr<ProductDescriptionBlockImpl> p;
class Impl;
std::unique_ptr<Impl> p;
};
} // namespace scwx::wsr88d::rpg