Archive warnings clang-tidy fixes

This commit is contained in:
Dan Paulat 2025-04-27 13:40:04 -05:00
parent 8cdd8526eb
commit 81f09e07f0
14 changed files with 43 additions and 46 deletions

View file

@ -9,6 +9,7 @@
#include <filesystem>
#include <shared_mutex>
#include <utility>
#include <vector>
#include <string>
#include <unordered_map>
@ -70,7 +71,7 @@ public:
class MarkerManager::Impl::MarkerRecord
{
public:
MarkerRecord(const types::MarkerInfo& info) : markerInfo_ {info} {}
MarkerRecord(types::MarkerInfo info) : markerInfo_ {std::move(info)} {}
const types::MarkerInfo& toMarkerInfo() { return markerInfo_; }

View file

@ -241,7 +241,7 @@ void TextEventManager::SelectTime(
boost::asio::post(
p->threadPool_,
[=, this]()
[this]()
{
try
{
@ -259,7 +259,7 @@ void TextEventManager::SelectTime(
date < p->archiveLimit_;
});
std::unique_lock lock {p->archiveMutex_};
const std::unique_lock lock {p->archiveMutex_};
p->UpdateArchiveDates(dates);
p->ListArchives(dates);
@ -382,7 +382,7 @@ void TextEventManager::Impl::ListArchives(DateRange dates)
auto productEntries = provider::IemApiProvider::ListTextProducts(
dateArray | ranges::views::all, kEmptyRange_, kPilsView_);
std::unique_lock lock {unloadedProductMapMutex_};
const std::unique_lock lock {unloadedProductMapMutex_};
if (productEntries.has_value())
{

View file

@ -24,7 +24,7 @@ public:
static std::shared_ptr<TimelineManager> Instance();
std::chrono::system_clock::time_point GetSelectedTime() const;
[[nodiscard]] std::chrono::system_clock::time_point GetSelectedTime() const;
void SetMapCount(std::size_t mapCount);

View file

@ -126,7 +126,7 @@ size_t UpdateManager::Impl::PopulateReleases()
// Successful REST API query
if (r.status_code == 200)
{
boost::json::value json = util::json::ReadJsonString(r.text);
const boost::json::value json = util::json::ReadJsonString(r.text);
if (json == nullptr)
{
logger_->warn("Response not JSON: {}", r.header["content-type"]);