blakeridgway/supercell-wx
1
0
Fork 0
mirror of https://github.com/ciphervance/supercell-wx.git synced 2025-10-30 19:10:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Return fields by value instead of const reference

Browse source
This commit is contained in:
Dan Paulat 2022-01-23 19:55:56 -06:00
parent c47a569645
commit 835ee644b5
10 changed files with 481 additions and 483 deletions
Download patch file Download diff file Expand all files Collapse all files

18
wxdata/source/scwx/awips/wmo_header.cpp
View file

@ -74,47 +74,47 @@ bool WmoHeaderImpl::operator==(const WmoHeaderImpl& o) const
productDesignator_ == o.productDesignator_);
}
const std::string& WmoHeader::sequence_number() const
std::string WmoHeader::sequence_number() const
{
return p->sequenceNumber_;
}
const std::string& WmoHeader::data_type() const
std::string WmoHeader::data_type() const
{
return p->dataType_;
}
const std::string& WmoHeader::geographic_designator() const
std::string WmoHeader::geographic_designator() const
{
return p->geographicDesignator_;
}
const std::string& WmoHeader::bulletin_id() const
std::string WmoHeader::bulletin_id() const
{
return p->bulletinId_;
}
const std::string& WmoHeader::icao() const
std::string WmoHeader::icao() const
{
return p->icao_;
}
const std::string& WmoHeader::date_time() const
std::string WmoHeader::date_time() const
{
return p->dateTime_;
}
const std::string& WmoHeader::bbb_indicator() const
std::string WmoHeader::bbb_indicator() const
{
return p->bbbIndicator_;
}
const std::string& WmoHeader::product_category() const
std::string WmoHeader::product_category() const
{
return p->productCategory_;
}
const std::string& WmoHeader::product_designator() const
std::string WmoHeader::product_designator() const
{
return p->productDesignator_;
}

14
wxdata/source/scwx/common/products.cpp
View file

@ -47,14 +47,13 @@ const std::string& GetProductGroupName(RadarProductGroup group)
return productGroupName_.at(group);
}
const RadarProductGroup GetProductGroup(const std::string& name)
RadarProductGroup GetProductGroup(const std::string& name)
{
auto result = std::find_if(
productGroupName_.cbegin(),
productGroupName_.cend(),
[&](const std::pair<RadarProductGroup, std::string>& pair) -> bool {
return pair.second == name;
});
[&](const std::pair<RadarProductGroup, std::string>& pair) -> bool
{ return pair.second == name; });
if (result != productGroupName_.cend())
{
@ -81,14 +80,13 @@ const std::string& GetLevel2Palette(Level2Product product)
return level2Palette_.at(product);
}
const Level2Product GetLevel2Product(const std::string& name)
Level2Product GetLevel2Product(const std::string& name)
{
auto result = std::find_if(
level2Name_.cbegin(),
level2Name_.cend(),
[&](const std::pair<Level2Product, std::string>& pair) -> bool {
return pair.second == name;
});
[&](const std::pair<Level2Product, std::string>& pair) -> bool
{ return pair.second == name; });
if (result != level2Name_.cend())
{

2
wxdata/source/scwx/wsr88d/rda/digital_radar_data.cpp
View file

@ -550,7 +550,7 @@ DigitalRadarData::DigitalRadarData(DigitalRadarData&&) noexcept = default;
DigitalRadarData&
DigitalRadarData::operator=(DigitalRadarData&&) noexcept = default;
const std::string& DigitalRadarData::radar_identifier() const
std::string DigitalRadarData::radar_identifier() const
{
return p->radarIdentifier_;
}

2
wxdata/source/scwx/wsr88d/rda/performance_maintenance_data.cpp
View file

@ -821,7 +821,7 @@ uint16_t PerformanceMaintenanceData::rcp_status() const
return p->rcpStatus_;
}
const std::string& PerformanceMaintenanceData::rcp_string() const
std::string PerformanceMaintenanceData::rcp_string() const
{
return p->rcpString_;
}

12
wxdata/source/scwx/wsr88d/rda/rda_adaptation_data.cpp
View file

@ -378,27 +378,27 @@ RdaAdaptationData::RdaAdaptationData(RdaAdaptationData&&) noexcept = default;
RdaAdaptationData&
RdaAdaptationData::operator=(RdaAdaptationData&&) noexcept = default;
const std::string& RdaAdaptationData::adap_file_name() const
std::string RdaAdaptationData::adap_file_name() const
{
return p->adapFileName_;
}
const std::string& RdaAdaptationData::adap_format() const
std::string RdaAdaptationData::adap_format() const
{
return p->adapFormat_;
}
const std::string& RdaAdaptationData::adap_revision() const
std::string RdaAdaptationData::adap_revision() const
{
return p->adapRevision_;
}
const std::string& RdaAdaptationData::adap_date() const
std::string RdaAdaptationData::adap_date() const
{
return p->adapDate_;
}
const std::string& RdaAdaptationData::adap_time() const
std::string RdaAdaptationData::adap_time() const
{
return p->adapTime_;
}
@ -878,7 +878,7 @@ float RdaAdaptationData::el_correction_factor() const
return p->elCorrectionFactor_;
}
const std::string& RdaAdaptationData::site_name() const
std::string RdaAdaptationData::site_name() const
{
return p->siteName_;
}