blakeridgway/supercell-wx
1
0
Fork 0
mirror of https://github.com/ciphervance/supercell-wx.git synced 2025-10-31 08:10:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Robust coded location error handling

Browse source
This commit is contained in:
Dan Paulat 2022-01-27 00:52:30 -06:00
parent 7d503ec506
commit 8f3baaa7c3
4 changed files with 131 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

40
wxdata/source/scwx/awips/coded_location.cpp
View file

@ -82,9 +82,23 @@ bool CodedLocation::Parse(const StringRange& lines, const std::string& wfo)
for (auto token = tokenList.cbegin() + 1; token != tokenList.cend();
++token)
{
double latitude = std::stod(*token) * 0.01;
++token;
double longitude = std::stod(*token) * 0.01;
double latitude = 0.0;
double longitude = 0.0;
try
{
latitude = std::stod(*token) * 0.01;
++token;
longitude = std::stod(*token) * 0.01;
}
catch (const std::exception& ex)
{
BOOST_LOG_TRIVIAL(warning)
<< logPrefix_ << "Invalid WFO location token: \"" << *token
<< "\" (" << ex.what() << ")";
dataValid = false;
break;
}
// If a given product straddles 180 degrees longitude, those points
// west of 180 degrees will be given as if they were west longitude
@ -99,7 +113,7 @@ bool CodedLocation::Parse(const StringRange& lines, const std::string& wfo)
p->coordinates_.push_back({latitude, longitude});
}
if (!wfoIsWest && straddlesDateLine)
if (dataValid && !wfoIsWest && straddlesDateLine)
{
for (auto& coordinate : p->coordinates_)
{
@ -123,8 +137,22 @@ bool CodedLocation::Parse(const StringRange& lines, const std::string& wfo)
break;
}
double latitude = std::stod(token->substr(0, 4)) * 0.01;
double longitude = std::stod(token->substr(4, 4)) * -0.01;
double latitude = 0.0;
double longitude = 0.0;
try
{
latitude = std::stod(token->substr(0, 4)) * 0.01;
longitude = std::stod(token->substr(4, 4)) * -0.01;
}
catch (const std::exception& ex)
{
BOOST_LOG_TRIVIAL(warning)
<< logPrefix_ << "Invalid National Center location token: \""
<< *token << "\" (" << ex.what() << ")";
dataValid = false;
break;
}
// Longitudes of greater than 100 degrees will drop the leading 1;
// i.e., 105.22 W would be coded as 0522. This is ambiguous

47
wxdata/source/scwx/awips/coded_time_motion_location.cpp
View file

@ -122,8 +122,18 @@ bool CodedTimeMotionLocation::Parse(const StringRange& lines,
std::string direction = tokenList.at(2);
if (direction.size() == 6 && direction.ends_with("DEG"))
{
p->direction_ =
static_cast<uint16_t>(std::stoul(direction.substr(0, 3)));
try
{
p->direction_ =
static_cast<uint16_t>(std::stoul(direction.substr(0, 3)));
}
catch (const std::exception& ex)
{
BOOST_LOG_TRIVIAL(warning)
<< logPrefix_ << "Invalid direction: \"" << direction << "\" ("
<< ex.what() << ")";
dataValid = false;
}
}
else
{
@ -136,8 +146,17 @@ bool CodedTimeMotionLocation::Parse(const StringRange& lines,
std::string speed = tokenList.at(3);
if (speed.size() >= 3 && speed.size() <= 4 && speed.ends_with("KT"))
{
p->speed_ =
static_cast<uint8_t>(std::stoul(speed.substr(0, speed.size() - 2)));
try
{
p->speed_ = static_cast<uint8_t>(
std::stoul(speed.substr(0, speed.size() - 2)));
}
catch (const std::exception& ex)
{
BOOST_LOG_TRIVIAL(warning) << logPrefix_ << "Invalid speed: \""
<< speed << "\" (" << ex.what() << ")";
dataValid = false;
}
}
else
{
@ -150,9 +169,23 @@ bool CodedTimeMotionLocation::Parse(const StringRange& lines,
for (auto token = tokenList.cbegin() + 4; token != tokenList.cend();
++token)
{
double latitude = std::stod(*token) * 0.01;
++token;
double longitude = std::stod(*token) * 0.01;
double latitude = 0.0;
double longitude = 0.0;
try
{
latitude = std::stod(*token) * 0.01;
++token;
longitude = std::stod(*token) * 0.01;
}
catch (const std::exception& ex)
{
BOOST_LOG_TRIVIAL(warning)
<< logPrefix_ << "Invalid location token: \"" << *token << "\" ("
<< ex.what() << ")";
dataValid = false;
break;
}
// If a given product straddles 180 degrees longitude, those points
// west of 180 degrees will be given as if they were west longitude