blakeridgway/supercell-wx
1
0
Fork 0
mirror of https://github.com/ciphervance/supercell-wx.git synced 2025-11-02 15:20:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Clean up placefile shared pointer usage with const references

Browse source
This commit is contained in:
Dan Paulat 2023-08-22 21:52:11 -05:00
parent 232fafc9fa
commit 9955c4ccbe
12 changed files with 33 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

10
scwx-qt/source/scwx/qt/gl/draw/placefile_icons.cpp
View file

@ -54,7 +54,7 @@ struct PlacefileIconInfo
class PlacefileIcons::Impl
{
public:
explicit Impl(std::shared_ptr<GlContext> context) :
explicit Impl(const std::shared_ptr<GlContext>& context) :
context_ {context},
shaderProgram_ {nullptr},
uMVPMatrixLocation_(GL_INVALID_INDEX),
@ -69,6 +69,9 @@ public:
~Impl() {}
void UpdateBuffers();
void Update(bool textureAtlasChanged);
std::shared_ptr<GlContext> context_;
bool dirty_ {false};
@ -98,12 +101,9 @@ public:
std::array<GLuint, 2> vbo_;
GLsizei numVertices_;
void UpdateBuffers();
void Update(bool textureAtlasChanged);
};
PlacefileIcons::PlacefileIcons(std::shared_ptr<GlContext> context) :
PlacefileIcons::PlacefileIcons(const std::shared_ptr<GlContext>& context) :
DrawItem(context->gl()), p(std::make_unique<Impl>(context))
{
}