Text and special symbol packet, fixing linked vector packet size

wxdata/source/scwx/wsr88d/rpg/linked_vector_packet.cpp

@@ -85,7 +85,7 @@ bool LinkedVectorPacket::Parse(std::istream& is)
    p->packetCode_    = ntohs(p->packetCode_);
    p->lengthOfBlock_ = ntohs(p->lengthOfBlock_);
 
-   int vectorSize = static_cast<int>(p->lengthOfBlock_) - 2;
+   int vectorSize = static_cast<int>(p->lengthOfBlock_) - 4;
 
    if (is.eof())
    {

wxdata/source/scwx/wsr88d/rpg/text_and_special_symbol_packet.cpp

@@ -0,0 +1,139 @@
+#include <scwx/wsr88d/rpg/text_and_special_symbol_packet.hpp>
+
+#include <istream>
+#include <string>
+
+#include <boost/log/trivial.hpp>
+
+namespace scwx
+{
+namespace wsr88d
+{
+namespace rpg
+{
+
+static const std::string logPrefix_ =
+   "[scwx::wsr88d::rpg::text_and_special_symbol_packet] ";
+
+class TextAndSpecialSymbolPacketImpl
+{
+public:
+   explicit TextAndSpecialSymbolPacketImpl() :
+       packetCode_ {},
+       lengthOfBlock_ {},
+       valueOfText_ {},
+       startI_ {},
+       startJ_ {},
+       characters_ {} {};
+   ~TextAndSpecialSymbolPacketImpl() = default;
+
+   uint16_t packetCode_;
+   uint16_t lengthOfBlock_;
+   uint16_t valueOfText_;
+   int16_t  startI_;
+   int16_t  startJ_;
+
+   std::vector<char> characters_;
+};
+
+TextAndSpecialSymbolPacket::TextAndSpecialSymbolPacket() :
+    p(std::make_unique<TextAndSpecialSymbolPacketImpl>())
+{
+}
+TextAndSpecialSymbolPacket::~TextAndSpecialSymbolPacket() = default;
+
+TextAndSpecialSymbolPacket::TextAndSpecialSymbolPacket(
+   TextAndSpecialSymbolPacket&&) noexcept                       = default;
+TextAndSpecialSymbolPacket& TextAndSpecialSymbolPacket::operator=(
+   TextAndSpecialSymbolPacket&&) noexcept = default;
+
+uint16_t TextAndSpecialSymbolPacket::packet_code() const
+{
+   return p->packetCode_;
+}
+
+uint16_t TextAndSpecialSymbolPacket::length_of_block() const
+{
+   return p->lengthOfBlock_;
+}
+
+std::optional<uint16_t> TextAndSpecialSymbolPacket::value_of_text() const
+{
+   std::optional<uint16_t> value;
+
+   if (p->packetCode_ == 8)
+   {
+      value = p->valueOfText_;
+   }
+
+   return value;
+}
+
+size_t TextAndSpecialSymbolPacket::data_size() const
+{
+   return p->lengthOfBlock_ + 4u;
+}
+
+bool TextAndSpecialSymbolPacket::Parse(std::istream& is)
+{
+   bool blockValid = true;
+
+   is.read(reinterpret_cast<char*>(&p->packetCode_), 2);
+   is.read(reinterpret_cast<char*>(&p->lengthOfBlock_), 2);
+
+   p->packetCode_    = ntohs(p->packetCode_);
+   p->lengthOfBlock_ = ntohs(p->lengthOfBlock_);
+
+   int vectorSize = static_cast<int>(p->lengthOfBlock_) - 4;
+
+   if (is.eof())
+   {
+      BOOST_LOG_TRIVIAL(debug) << logPrefix_ << "Reached end of file";
+      blockValid = false;
+   }
+   else if (p->packetCode_ == 8)
+   {
+      is.read(reinterpret_cast<char*>(&p->valueOfText_), 2);
+      p->valueOfText_ = ntohs(p->valueOfText_);
+
+      vectorSize -= 2;
+   }
+
+   is.read(reinterpret_cast<char*>(&p->startI_), 2);
+   is.read(reinterpret_cast<char*>(&p->startJ_), 2);
+
+   p->startI_ = ntohs(p->startI_);
+   p->startJ_ = ntohs(p->startJ_);
+
+   // The number of vectors is equal to the size divided by the number of bytes
+   // in a vector coordinate
+   int  vectorCount = vectorSize;
+   char c;
+
+   for (int v = 0; v < vectorCount && !is.eof(); v++)
+   {
+      is.get(c);
+      p->characters_.push_back(c);
+   }
+
+   if (is.eof())
+   {
+      BOOST_LOG_TRIVIAL(debug) << logPrefix_ << "Reached end of file";
+      blockValid = false;
+   }
+   else
+   {
+      if (p->packetCode_ != 1 && p->packetCode_ != 2 && p->packetCode_ != 8)
+      {
+         BOOST_LOG_TRIVIAL(warning)
+            << logPrefix_ << "Invalid packet code: " << p->packetCode_;
+         blockValid = false;
+      }
+   }
+
+   return blockValid;
+}
+
+} // namespace rpg
+} // namespace wsr88d
+} // namespace scwx