From b96455190faced1fd932c9c178d484016c3bfc49 Mon Sep 17 00:00:00 2001 From: Dan Paulat Date: Tue, 25 Jan 2022 21:39:48 -0600 Subject: [PATCH] Avoid potential undefined behavior in WMO header parsing, don't reuse moved string --- wxdata/source/scwx/awips/wmo_header.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wxdata/source/scwx/awips/wmo_header.cpp b/wxdata/source/scwx/awips/wmo_header.cpp index 2980b085..04a98192 100644 --- a/wxdata/source/scwx/awips/wmo_header.cpp +++ b/wxdata/source/scwx/awips/wmo_header.cpp @@ -171,7 +171,7 @@ bool WmoHeader::Parse(std::istream& is) while (wmoTokens >> token) { - wmoTokenList.push_back(std::move(token)); + wmoTokenList.push_back(token); } if (wmoTokenList.size() < 3 || wmoTokenList.size() > 4)