Return static constant data by constant reference

This commit is contained in:
Dan Paulat 2022-01-23 19:44:42 -06:00
parent a202e0e2a0
commit c47a569645
6 changed files with 16 additions and 16 deletions

View file

@ -68,9 +68,9 @@ enum class Phenomenon
Unknown
};
Phenomenon GetPhenomenon(const std::string& code);
std::string GetPhenomenonCode(Phenomenon phenomenon);
std::string GetPhenomenonText(Phenomenon phenomenon);
Phenomenon GetPhenomenon(const std::string& code);
const std::string& GetPhenomenonCode(Phenomenon phenomenon);
const std::string& GetPhenomenonText(Phenomenon phenomenon);
} // namespace awips
} // namespace scwx

View file

@ -61,11 +61,11 @@ public:
bool Parse(const std::string& s);
static ProductType GetProductType(const std::string& code);
static std::string GetProductTypeCode(ProductType productType);
static ProductType GetProductType(const std::string& code);
static const std::string& GetProductTypeCode(ProductType productType);
static Action GetAction(const std::string& code);
static std::string GetActionCode(Action action);
static Action GetAction(const std::string& code);
static const std::string& GetActionCode(Action action);
private:
std::unique_ptr<PVtecImpl> p;

View file

@ -19,9 +19,9 @@ enum class Significance
Unknown
};
Significance GetSignificance(const std::string& code);
std::string GetSignificanceCode(Significance significance);
std::string GetSignificanceText(Significance significance);
Significance GetSignificance(const std::string& code);
const std::string& GetSignificanceCode(Significance significance);
const std::string& GetSignificanceText(Significance significance);
} // namespace awips
} // namespace scwx