Use dynamically sized ImGui fonts

This commit is contained in:
Dan Paulat 2025-08-27 23:43:11 -05:00
parent dc96e3e3ad
commit c82b9753c6
12 changed files with 89 additions and 88 deletions

View file

@ -1,6 +1,5 @@
#include <scwx/qt/gl/draw/placefile_text.hpp> #include <scwx/qt/gl/draw/placefile_text.hpp>
#include <scwx/qt/manager/font_manager.hpp> #include <scwx/qt/manager/font_manager.hpp>
#include <scwx/qt/manager/placefile_manager.hpp>
#include <scwx/qt/settings/text_settings.hpp> #include <scwx/qt/settings/text_settings.hpp>
#include <scwx/qt/util/maplibre.hpp> #include <scwx/qt/util/maplibre.hpp>
#include <scwx/qt/util/tooltip.hpp> #include <scwx/qt/util/tooltip.hpp>
@ -62,8 +61,12 @@ public:
std::vector<std::shared_ptr<const gr::Placefile::TextDrawItem>> textList_ {}; std::vector<std::shared_ptr<const gr::Placefile::TextDrawItem>> textList_ {};
std::vector<std::shared_ptr<const gr::Placefile::TextDrawItem>> newList_ {}; std::vector<std::shared_ptr<const gr::Placefile::TextDrawItem>> newList_ {};
std::vector<std::shared_ptr<types::ImGuiFont>> fonts_ {}; std::vector<std::pair<std::shared_ptr<types::ImGuiFont>,
std::vector<std::shared_ptr<types::ImGuiFont>> newFonts_ {}; units::font_size::pixels<int>>>
fonts_ {};
std::vector<std::pair<std::shared_ptr<types::ImGuiFont>,
units::font_size::pixels<int>>>
newFonts_ {};
}; };
PlacefileText::PlacefileText(const std::string& placefileName) : PlacefileText::PlacefileText(const std::string& placefileName) :
@ -159,7 +162,8 @@ void PlacefileText::Impl::RenderTextDrawItem(
std::size_t fontNumber = std::clamp<std::size_t>(di->fontNumber_, 0, 8); std::size_t fontNumber = std::clamp<std::size_t>(di->fontNumber_, 0, 8);
// Set the font for the drop shadow and text // Set the font for the drop shadow and text
ImGui::PushFont(fonts_[fontNumber]->font(), 0.0f); ImGui::PushFont(fonts_[fontNumber].first->font(),
fonts_[fontNumber].second.value());
if (settings::TextSettings::Instance() if (settings::TextSettings::Instance()
.placefile_text_drop_shadow_enabled() .placefile_text_drop_shadow_enabled()
@ -261,9 +265,7 @@ void PlacefileText::StartText()
p->newList_.clear(); p->newList_.clear();
} }
void PlacefileText::SetFonts( void PlacefileText::SetFonts(const manager::PlacefileManager::FontMap& fonts)
const boost::unordered_flat_map<std::size_t,
std::shared_ptr<types::ImGuiFont>>& fonts)
{ {
auto defaultFont = manager::FontManager::Instance().GetImGuiFont( auto defaultFont = manager::FontManager::Instance().GetImGuiFont(
types::FontCategory::Default); types::FontCategory::Default);

View file

@ -2,6 +2,7 @@
#include <scwx/qt/gl/gl_context.hpp> #include <scwx/qt/gl/gl_context.hpp>
#include <scwx/qt/gl/draw/draw_item.hpp> #include <scwx/qt/gl/draw/draw_item.hpp>
#include <scwx/qt/manager/placefile_manager.hpp>
#include <scwx/qt/types/imgui_font.hpp> #include <scwx/qt/types/imgui_font.hpp>
#include <scwx/gr/placefile.hpp> #include <scwx/gr/placefile.hpp>
@ -54,10 +55,7 @@ public:
* *
* @param [in] fonts A map of ImGui fonts * @param [in] fonts A map of ImGui fonts
*/ */
void void SetFonts(const manager::PlacefileManager::FontMap& fonts);
SetFonts(const boost::unordered_flat_map<std::size_t,
std::shared_ptr<types::ImGuiFont>>&
fonts);
/** /**
* Adds placefile text to the internal draw list. * Adds placefile text to the internal draw list.

View file

@ -34,15 +34,13 @@ struct FontRecord
std::string filename_ {}; std::string filename_ {};
}; };
typedef std::pair<FontRecord, units::font_size::pixels<int>> FontRecordPair;
template<class Key> template<class Key>
struct FontRecordHash; struct FontRecordHash;
template<> template<>
struct FontRecordHash<FontRecordPair> struct FontRecordHash<FontRecord>
{ {
size_t operator()(const FontRecordPair& x) const; size_t operator()(const FontRecord& x) const;
}; };
class FontManager::Impl class FontManager::Impl
@ -77,18 +75,20 @@ public:
std::shared_mutex imguiFontAtlasMutex_ {}; std::shared_mutex imguiFontAtlasMutex_ {};
boost::unordered_flat_map<FontRecordPair, boost::unordered_flat_map<FontRecord,
std::shared_ptr<types::ImGuiFont>, std::shared_ptr<types::ImGuiFont>,
FontRecordHash<FontRecordPair>> FontRecordHash<FontRecord>>
imguiFonts_ {}; imguiFonts_ {};
std::shared_mutex imguiFontsMutex_ {}; std::shared_mutex imguiFontsMutex_ {};
boost::unordered_flat_map<std::string, std::vector<char>> rawFontData_ {}; boost::unordered_flat_map<std::string, std::vector<char>> rawFontData_ {};
std::mutex rawFontDataMutex_ {}; std::mutex rawFontDataMutex_ {};
std::shared_ptr<types::ImGuiFont> defaultFont_ {}; std::pair<std::shared_ptr<types::ImGuiFont>, units::font_size::pixels<int>>
defaultFont_ {};
boost::unordered_flat_map<types::FontCategory, boost::unordered_flat_map<types::FontCategory,
std::shared_ptr<types::ImGuiFont>> std::pair<std::shared_ptr<types::ImGuiFont>,
units::font_size::pixels<int>>>
fontCategoryImguiFontMap_ {}; fontCategoryImguiFontMap_ {};
boost::unordered_flat_map<types::FontCategory, QFont> boost::unordered_flat_map<types::FontCategory, QFont>
fontCategoryQFontMap_ {}; fontCategoryQFontMap_ {};
@ -160,6 +160,17 @@ void FontManager::InitializeFonts()
} }
} }
units::font_size::pixels<int>
FontManager::ImFontSize(units::font_size::pixels<double> size)
{
// Only allow whole pixels, and clamp to 6-72 pt
units::font_size::pixels<double> pixels {size};
units::font_size::pixels<int> imFontSize {
std::clamp(static_cast<int>(pixels.value()), 8, 96)};
return imFontSize;
}
void FontManager::Impl::UpdateImGuiFont(types::FontCategory fontCategory) void FontManager::Impl::UpdateImGuiFont(types::FontCategory fontCategory)
{ {
auto& textSettings = settings::TextSettings::Instance(); auto& textSettings = settings::TextSettings::Instance();
@ -170,7 +181,8 @@ void FontManager::Impl::UpdateImGuiFont(types::FontCategory fontCategory)
textSettings.font_point_size(fontCategory).GetValue()}; textSettings.font_point_size(fontCategory).GetValue()};
fontCategoryImguiFontMap_.insert_or_assign( fontCategoryImguiFontMap_.insert_or_assign(
fontCategory, self_->LoadImGuiFont(family, {styles}, size)); fontCategory,
std::make_pair(self_->LoadImGuiFont(family, {styles}), ImFontSize(size)));
} }
void FontManager::Impl::UpdateQFont(types::FontCategory fontCategory) void FontManager::Impl::UpdateQFont(types::FontCategory fontCategory)
@ -211,7 +223,7 @@ int FontManager::GetFontId(types::Font font) const
return -1; return -1;
} }
std::shared_ptr<types::ImGuiFont> std::pair<std::shared_ptr<types::ImGuiFont>, units::font_size::pixels<int>>
FontManager::GetImGuiFont(types::FontCategory fontCategory) FontManager::GetImGuiFont(types::FontCategory fontCategory)
{ {
std::unique_lock lock {p->fontCategoryMutex_}; std::unique_lock lock {p->fontCategoryMutex_};
@ -241,29 +253,21 @@ QFont FontManager::GetQFont(types::FontCategory fontCategory)
std::shared_ptr<types::ImGuiFont> std::shared_ptr<types::ImGuiFont>
FontManager::LoadImGuiFont(const std::string& family, FontManager::LoadImGuiFont(const std::string& family,
const std::vector<std::string>& styles, const std::vector<std::string>& styles,
units::font_size::points<double> size,
bool loadIfNotFound) bool loadIfNotFound)
{ {
const std::string styleString = fmt::format("{}", fmt::join(styles, " ")); const std::string styleString = fmt::format("{}", fmt::join(styles, " "));
const std::string fontString = const std::string fontString = fmt::format("{}:{}", family, styleString);
fmt::format("{}-{}:{}", family, size.value(), styleString);
logger_->debug("LoadFontResource: {}", fontString); logger_->debug("LoadFontResource: {}", fontString);
FontRecord fontRecord = Impl::MatchFontFile(family, styles); FontRecord fontRecord = Impl::MatchFontFile(family, styles);
// Only allow whole pixels, and clamp to 6-72 pt
units::font_size::pixels<double> pixels {size};
units::font_size::pixels<int> imFontSize {
std::clamp(static_cast<int>(pixels.value()), 8, 96)};
auto imguiFontKey = std::make_pair(fontRecord, imFontSize);
// Search for a loaded ImGui font // Search for a loaded ImGui font
{ {
std::shared_lock imguiFontLock {p->imguiFontsMutex_}; std::shared_lock imguiFontLock {p->imguiFontsMutex_};
// Search for the associated ImGui font // Search for the associated ImGui font
auto it = p->imguiFonts_.find(imguiFontKey); auto it = p->imguiFonts_.find(fontRecord);
if (it != p->imguiFonts_.end()) if (it != p->imguiFonts_.end())
{ {
return it->second; return it->second;
@ -288,7 +292,7 @@ FontManager::LoadImGuiFont(const std::string& family,
// Search for the associated ImGui font again, to prevent loading the same // Search for the associated ImGui font again, to prevent loading the same
// font twice // font twice
auto it = p->imguiFonts_.find(imguiFontKey); auto it = p->imguiFonts_.find(fontRecord);
if (it != p->imguiFonts_.end()) if (it != p->imguiFonts_.end())
{ {
return it->second; return it->second;
@ -299,22 +303,20 @@ FontManager::LoadImGuiFont(const std::string& family,
try try
{ {
fontName = fmt::format( fontName = fmt::format(
"{}:{}", "{}", std::filesystem::path(fontRecord.filename_).filename().string());
std::filesystem::path(fontRecord.filename_).filename().string(),
imFontSize.value());
} }
catch (const std::exception& ex) catch (const std::exception& ex)
{ {
logger_->warn(ex.what()); logger_->warn(ex.what());
fontName = fmt::format("{}:{}", fontRecord.filename_, imFontSize.value()); fontName = fmt::format("{}", fontRecord.filename_);
} }
// Create an ImGui font // Create an ImGui font
std::shared_ptr<types::ImGuiFont> imguiFont = std::shared_ptr<types::ImGuiFont> imguiFont =
std::make_shared<types::ImGuiFont>(fontName, rawFontData, imFontSize); std::make_shared<types::ImGuiFont>(fontName, rawFontData);
// Store the ImGui font // Store the ImGui font
p->imguiFonts_.insert_or_assign(imguiFontKey, imguiFont); p->imguiFonts_.insert_or_assign(fontRecord, imguiFont);
// Return the ImGui font // Return the ImGui font
return imguiFont; return imguiFont;
@ -554,13 +556,12 @@ FontManager& FontManager::Instance()
return instance_; return instance_;
} }
size_t FontRecordHash<FontRecordPair>::operator()(const FontRecordPair& x) const size_t FontRecordHash<FontRecord>::operator()(const FontRecord& x) const
{ {
size_t seed = 0; size_t seed = 0;
boost::hash_combine(seed, x.first.family_); boost::hash_combine(seed, x.family_);
boost::hash_combine(seed, x.first.style_); boost::hash_combine(seed, x.style_);
boost::hash_combine(seed, x.first.filename_); boost::hash_combine(seed, x.filename_);
boost::hash_combine(seed, x.second.value());
return seed; return seed;
} }

View file

@ -28,18 +28,20 @@ public:
std::shared_mutex& imgui_font_atlas_mutex(); std::shared_mutex& imgui_font_atlas_mutex();
int GetFontId(types::Font font) const; int GetFontId(types::Font font) const;
std::shared_ptr<types::ImGuiFont> std::pair<std::shared_ptr<types::ImGuiFont>, units::font_size::pixels<int>>
GetImGuiFont(types::FontCategory fontCategory); GetImGuiFont(types::FontCategory fontCategory);
QFont GetQFont(types::FontCategory fontCategory); QFont GetQFont(types::FontCategory fontCategory);
std::shared_ptr<types::ImGuiFont> std::shared_ptr<types::ImGuiFont>
LoadImGuiFont(const std::string& family, LoadImGuiFont(const std::string& family,
const std::vector<std::string>& styles, const std::vector<std::string>& styles,
units::font_size::points<double> size,
bool loadIfNotFound = true); bool loadIfNotFound = true);
void LoadApplicationFont(types::Font font, const std::string& filename); void LoadApplicationFont(types::Font font, const std::string& filename);
void InitializeFonts(); void InitializeFonts();
static units::font_size::pixels<int>
ImFontSize(units::font_size::pixels<double> size);
static FontManager& Instance(); static FontManager& Instance();
private: private:

View file

@ -52,8 +52,7 @@ public:
void ReadPlacefileSettings(); void ReadPlacefileSettings();
void WritePlacefileSettings(); void WritePlacefileSettings();
static boost::unordered_flat_map<std::size_t, static FontMap
std::shared_ptr<types::ImGuiFont>>
LoadFontResources(const std::shared_ptr<gr::Placefile>& placefile); LoadFontResources(const std::shared_ptr<gr::Placefile>& placefile);
static std::vector<std::shared_ptr<boost::gil::rgba8_image_t>> static std::vector<std::shared_ptr<boost::gil::rgba8_image_t>>
LoadImageResources(const std::shared_ptr<gr::Placefile>& placefile); LoadImageResources(const std::shared_ptr<gr::Placefile>& placefile);
@ -147,8 +146,7 @@ public:
std::mutex refreshMutex_ {}; std::mutex refreshMutex_ {};
std::mutex timerMutex_ {}; std::mutex timerMutex_ {};
boost::unordered_flat_map<std::size_t, std::shared_ptr<types::ImGuiFont>> FontMap fonts_ {};
fonts_ {};
std::mutex fontsMutex_ {}; std::mutex fontsMutex_ {};
std::vector<std::shared_ptr<boost::gil::rgba8_image_t>> images_ {}; std::vector<std::shared_ptr<boost::gil::rgba8_image_t>> images_ {};
@ -235,7 +233,7 @@ PlacefileManager::placefile(const std::string& name)
return nullptr; return nullptr;
} }
boost::unordered_flat_map<std::size_t, std::shared_ptr<types::ImGuiFont>> PlacefileManager::FontMap
PlacefileManager::placefile_fonts(const std::string& name) PlacefileManager::placefile_fonts(const std::string& name)
{ {
std::shared_lock lock(p->placefileRecordLock_); std::shared_lock lock(p->placefileRecordLock_);
@ -775,12 +773,10 @@ std::shared_ptr<PlacefileManager> PlacefileManager::Instance()
return placefileManager; return placefileManager;
} }
boost::unordered_flat_map<std::size_t, std::shared_ptr<types::ImGuiFont>> PlacefileManager::FontMap PlacefileManager::Impl::LoadFontResources(
PlacefileManager::Impl::LoadFontResources(
const std::shared_ptr<gr::Placefile>& placefile) const std::shared_ptr<gr::Placefile>& placefile)
{ {
boost::unordered_flat_map<std::size_t, std::shared_ptr<types::ImGuiFont>> FontMap imGuiFonts {};
imGuiFonts {};
auto fonts = placefile->fonts(); auto fonts = placefile->fonts();
for (auto& font : fonts) for (auto& font : fonts)
@ -797,9 +793,11 @@ PlacefileManager::Impl::LoadFontResources(
styles.push_back("italic"); styles.push_back("italic");
} }
auto imGuiFont = FontManager::Instance().LoadImGuiFont( auto imGuiFont =
font.second->face_, styles, size); FontManager::Instance().LoadImGuiFont(font.second->face_, styles);
imGuiFonts.emplace(font.first, std::move(imGuiFont)); imGuiFonts.emplace(
font.first,
std::make_pair(std::move(imGuiFont), FontManager::ImFontSize(size)));
} }
return imGuiFonts; return imGuiFonts;

View file

@ -2,6 +2,7 @@
#include <scwx/gr/placefile.hpp> #include <scwx/gr/placefile.hpp>
#include <scwx/qt/config/radar_site.hpp> #include <scwx/qt/config/radar_site.hpp>
#include <scwx/qt/types/font_types.hpp>
#include <scwx/qt/types/imgui_font.hpp> #include <scwx/qt/types/imgui_font.hpp>
#include <QObject> #include <QObject>
@ -22,12 +23,16 @@ public:
explicit PlacefileManager(); explicit PlacefileManager();
~PlacefileManager(); ~PlacefileManager();
using FontMap =
boost::unordered_flat_map<std::size_t,
std::pair<std::shared_ptr<types::ImGuiFont>,
units::font_size::pixels<int>>>;
bool placefile_enabled(const std::string& name); bool placefile_enabled(const std::string& name);
bool placefile_thresholded(const std::string& name); bool placefile_thresholded(const std::string& name);
std::string placefile_title(const std::string& name); std::string placefile_title(const std::string& name);
std::shared_ptr<gr::Placefile> placefile(const std::string& name); std::shared_ptr<gr::Placefile> placefile(const std::string& name);
boost::unordered_flat_map<std::size_t, std::shared_ptr<types::ImGuiFont>> FontMap placefile_fonts(const std::string& name);
placefile_fonts(const std::string& name);
void set_placefile_enabled(const std::string& name, bool enabled); void set_placefile_enabled(const std::string& name, bool enabled);
void set_placefile_thresholded(const std::string& name, bool thresholded); void set_placefile_thresholded(const std::string& name, bool thresholded);

View file

@ -102,7 +102,7 @@ void DrawLayer::ImGuiFrameStart(const std::shared_ptr<MapContext>& mapContext)
ImGui_ImplQt_NewFrame(mapContext->widget()); ImGui_ImplQt_NewFrame(mapContext->widget());
ImGui_ImplOpenGL3_NewFrame(); ImGui_ImplOpenGL3_NewFrame();
ImGui::NewFrame(); ImGui::NewFrame();
ImGui::PushFont(defaultFont->font(), 0.0f); ImGui::PushFont(defaultFont.first->font(), defaultFont.second.value());
} }
void DrawLayer::ImGuiFrameEnd() void DrawLayer::ImGuiFrameEnd()

View file

@ -1644,7 +1644,7 @@ void MapWidget::paintGL()
ImGui::NewFrame(); ImGui::NewFrame();
// Set default font // Set default font
ImGui::PushFont(defaultFont->font(), 0.0f); ImGui::PushFont(defaultFont.first->font(), defaultFont.second.value());
// Perform mouse picking // Perform mouse picking
if (p->hasMouse_) if (p->hasMouse_)

View file

@ -539,7 +539,8 @@ void OverlayLayer::Render(const std::shared_ptr<MapContext>& mapContext,
ImVec2 {1.0f, 1.0f}); ImVec2 {1.0f, 1.0f});
ImGui::SetNextWindowBgAlpha(0.5f); ImGui::SetNextWindowBgAlpha(0.5f);
ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2 {3.0f, 2.0f}); ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2 {3.0f, 2.0f});
ImGui::PushFont(attributionFont->font(), 0.0f); ImGui::PushFont(attributionFont.first->font(),
attributionFont.second.value());
ImGui::Begin("Attribution", ImGui::Begin("Attribution",
nullptr, nullptr,
ImGuiWindowFlags_NoTitleBar | ImGuiWindowFlags_NoResize | ImGuiWindowFlags_NoTitleBar | ImGuiWindowFlags_NoResize |

View file

@ -24,9 +24,8 @@ class ImGuiFont::Impl
{ {
public: public:
explicit Impl(const std::string& fontName, explicit Impl(const std::string& fontName,
const std::vector<char>& fontData, const std::vector<char>& fontData) :
units::font_size::pixels<int> size) : fontName_ {fontName}
fontName_ {fontName}, size_ {size}
{ {
CreateImGuiFont(fontData); CreateImGuiFont(fontData);
} }
@ -36,15 +35,13 @@ public:
void CreateImGuiFont(const std::vector<char>& fontData); void CreateImGuiFont(const std::vector<char>& fontData);
const std::string fontName_; const std::string fontName_;
const units::font_size::pixels<int> size_;
ImFont* imFont_ {nullptr}; ImFont* imFont_ {nullptr};
}; };
ImGuiFont::ImGuiFont(const std::string& fontName, ImGuiFont::ImGuiFont(const std::string& fontName,
const std::vector<char>& fontData, const std::vector<char>& fontData) :
units::font_size::pixels<int> size) : p(std::make_unique<Impl>(fontName, fontData))
p(std::make_unique<Impl>(fontName, fontData, size))
{ {
} }
ImGuiFont::~ImGuiFont() = default; ImGuiFont::~ImGuiFont() = default;
@ -53,11 +50,11 @@ void ImGuiFont::Impl::CreateImGuiFont(const std::vector<char>& fontData)
{ {
logger_->debug("Creating Font: {}", fontName_); logger_->debug("Creating Font: {}", fontName_);
static constexpr float kSizePixels_ = 0.0f;
ImFontAtlas* fontAtlas = model::ImGuiContextModel::Instance().font_atlas(); ImFontAtlas* fontAtlas = model::ImGuiContextModel::Instance().font_atlas();
ImFontConfig fontConfig {}; ImFontConfig fontConfig {};
const float sizePixels = static_cast<float>(size_.value());
// Do not transfer ownership of font data to ImGui, makes const_cast safe // Do not transfer ownership of font data to ImGui, makes const_cast safe
fontConfig.FontDataOwnedByAtlas = false; fontConfig.FontDataOwnedByAtlas = false;
@ -69,7 +66,7 @@ void ImGuiFont::Impl::CreateImGuiFont(const std::vector<char>& fontData)
const_cast<void*>(static_cast<const void*>(fontData.data())), const_cast<void*>(static_cast<const void*>(fontData.data())),
static_cast<int>(std::clamp<std::size_t>( static_cast<int>(std::clamp<std::size_t>(
fontData.size(), 0, std::numeric_limits<int>::max())), fontData.size(), 0, std::numeric_limits<int>::max())),
sizePixels, kSizePixels_,
&fontConfig); &fontConfig);
} }

View file

@ -4,8 +4,6 @@
#include <string> #include <string>
#include <vector> #include <vector>
#include <scwx/qt/types/font_types.hpp>
struct ImFont; struct ImFont;
namespace scwx namespace scwx
@ -19,8 +17,7 @@ class ImGuiFont
{ {
public: public:
explicit ImGuiFont(const std::string& fontName, explicit ImGuiFont(const std::string& fontName,
const std::vector<char>& fontData, const std::vector<char>& fontData);
units::font_size::pixels<int> size);
~ImGuiFont(); ~ImGuiFont();
ImGuiFont(const ImGuiFont&) = delete; ImGuiFont(const ImGuiFont&) = delete;

View file

@ -34,7 +34,7 @@ void ImGui::DrawTooltip(const std::string& hoverText)
if (::ImGui::BeginTooltip()) if (::ImGui::BeginTooltip())
{ {
::ImGui::PushFont(tooltipFont->font(), 0.0f); ::ImGui::PushFont(tooltipFont.first->font(), tooltipFont.second.value());
::ImGui::TextUnformatted(hoverText.c_str()); ::ImGui::TextUnformatted(hoverText.c_str());
::ImGui::PopFont(); ::ImGui::PopFont();
::ImGui::EndTooltip(); ::ImGui::EndTooltip();