NOMINMAX should be defined for the entire project

This commit is contained in:
Dan Paulat 2023-11-19 20:56:03 -06:00
parent ff7f70a5b7
commit dd1490a143
7 changed files with 11 additions and 9 deletions

View file

@ -462,6 +462,12 @@ target_compile_options(supercell-wx PRIVATE
$<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic -Werror> $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic -Werror>
) )
if (MSVC)
# Don't include Windows macros
target_compile_options(scwx-qt PRIVATE /D "NOMINMAX")
target_compile_options(supercell-wx PRIVATE /D "NOMINMAX")
endif()
# Address Sanitizer options # Address Sanitizer options
if (SCWX_ADDRESS_SANITIZER) if (SCWX_ADDRESS_SANITIZER)
target_compile_options(scwx-qt PRIVATE target_compile_options(scwx-qt PRIVATE

View file

@ -1,4 +1,3 @@
#define NOMINMAX
#define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING #define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING
#include <scwx/qt/config/radar_site.hpp> #include <scwx/qt/config/radar_site.hpp>

View file

@ -1,5 +1,3 @@
#define NOMINMAX
#include "main_window.hpp" #include "main_window.hpp"
#include "./ui_main_window.h" #include "./ui_main_window.h"

View file

@ -1,5 +1,3 @@
#define NOMINMAX
#include <scwx/qt/manager/placefile_manager.hpp> #include <scwx/qt/manager/placefile_manager.hpp>
#include <scwx/qt/manager/font_manager.hpp> #include <scwx/qt/manager/font_manager.hpp>
#include <scwx/qt/manager/resource_manager.hpp> #include <scwx/qt/manager/resource_manager.hpp>

View file

@ -1,5 +1,3 @@
#define NOMINMAX
#include <scwx/qt/manager/timeline_manager.hpp> #include <scwx/qt/manager/timeline_manager.hpp>
#include <scwx/qt/manager/radar_product_manager.hpp> #include <scwx/qt/manager/radar_product_manager.hpp>
#include <scwx/qt/settings/general_settings.hpp> #include <scwx/qt/settings/general_settings.hpp>

View file

@ -1,5 +1,3 @@
#define NOMINMAX
#include <scwx/qt/model/alert_model.hpp> #include <scwx/qt/model/alert_model.hpp>
#include <scwx/qt/config/county_database.hpp> #include <scwx/qt/config/county_database.hpp>
#include <scwx/qt/manager/text_event_manager.hpp> #include <scwx/qt/manager/text_event_manager.hpp>

View file

@ -248,6 +248,11 @@ target_compile_options(wxdata PRIVATE
$<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic -Werror> $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic -Werror>
) )
if (MSVC)
# Don't include Windows macros
target_compile_options(wxdata PRIVATE /D "NOMINMAX")
endif()
if (MSVC) if (MSVC)
# Produce PDB file for debug # Produce PDB file for debug
target_compile_options(wxdata PRIVATE "$<$<CONFIG:Release>:/Zi>") target_compile_options(wxdata PRIVATE "$<$<CONFIG:Release>:/Zi>")